Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add utility returning hashed version of firmware-uuid of a L1T menu #41633

Merged
merged 1 commit into from
May 15, 2023
Merged

add utility returning hashed version of firmware-uuid of a L1T menu #41633

merged 1 commit into from
May 15, 2023
+53 −0

Conversation

missirol
Copy link
Contributor

@missirol missirol commented May 11, 2023 •
edited
Loading

PR description:

This PR adds a simple cpp program to get the hashed version of the firmware-uuid of a L1T menu.

This utility can be useful in debugging exceptions thrown by L1TGlobalProducer like the one below:

An exception of category 'ConditionsError' occurred while
[0] Processing Event run: 367301 lumi: 10 event: 105191 stream: 23
[1] Running path 'HLT_DoubleEle10_eta1p22_mMax6_trkHits10_v2'
[2] Calling method for module L1TGlobalProducer/'hltGtStage2ObjectMap'
Exception Message:
Error L1 menu loaded in via conditions does not match the L1 actually run -931659658 vs 1554451404.
This means that the mapping of the names to the bits may be incorrect.
Please check the L1TUtmTriggerMenuRcd record supplied.
Unless you know what you are doing, do not simply disable this check via the config
as this a major error and the indication of something very wrong

PR validation:

The corresponding executable works as expected. Example:

$ l1tHashMenuFirmwareUUID 7a1a9c0b-5e34-4c25-804f-2ae8094c4832
1554451404

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone May 11, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41633/35521

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • CondFormats/L1TObjects (l1, db, alca)

@epalencia, @cmsbuild, @saumyaphor4252, @aloeliger, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

+l1

mmusich
mmusich reviewed May 11, 2023
View reviewed changes
CondFormats/L1TObjects/bin/l1tMenuFirmwareUUIDHashed.cpp Outdated
@@ -0,0 +1,51 @@
#include <iostream>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably CondTools/L1Trigger might be a better location for this?

@missirol
Copy link
Contributor Author

please abort

@missirol missirol force-pushed the devel_l1tMenuFirmwareUUIDHashed branch from 7f0ccfe to afbd0d9 Compare May 11, 2023 19:04
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41633/35524

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #41633 was updated. @epalencia, @cmsbuild, @saumyaphor4252, @aloeliger, @francescobrivio, @cecilecaillol, @tvami can you please check and sign again.

@missirol
Copy link
Contributor Author

Moved to CondTools, applied minor changes, and renamed the utility (l1tHashMenuFirmwareUUID is a bit clearer, arguably).

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afafb7/32582/summary.html
COMMIT: afbd0d9
CMSSW: CMSSW_13_2_X_2023-05-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41633/32582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3461906
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461875
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@missirol Is this part of the ongoing packer/unpacker debugging?

@missirol
Copy link
Contributor Author

Is this part of the ongoing packer/unpacker debugging?

No, just a different unrelated issue that occurred in run-367301.

@missirol
Copy link
Contributor Author

@cms-sw/db-l2

Could you please review this PR ?

@francescobrivio
Copy link
Contributor

+db

  • adding useful script for debugging of possible L1T firmware issues
  • tests are clean

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e2d3811 into cms-sw:master May 15, 2023
@cmsbuild cmsbuild mentioned this pull request May 15, 2023
Merged
@missirol missirol deleted the devel_l1tMenuFirmwareUUIDHashed branch June 15, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmusich mmusich mmusich left review comments

Assignees
No one assigned
Labels
code-checks-approved db-approved fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_2_X
Development

Successfully merging this pull request may close these issues.
6 participants
@missirol @cmsbuild @aloeliger @francescobrivio @perrotta @mmusich